[DPE-1423] Update ocean-kubernetes-controller version to 0.1.59 #73
Conversation
* Swap to the new published module for ocean
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/dpe-dev-kubernetes-deployments
| drop: | ||
| - ALL | ||
|
|
||
| command: [] |
There was a problem hiding this comment.
Why do we need to set command: []? Does it mean to use the default entry point?
There was a problem hiding this comment.
I'm not exactly sure. Many of these changes are what the developers have as defaults, so I decided to leave them in.
In helm when you run
helm show values spot/ocean-kubernetes-controller
It gives you what their default values file is for the version you are using. The changes you see in the values file are what their new suggested defaults are, and I kept a bit of our specific configuration as well that isn't the same as the default.
There was a problem hiding this comment.
Ah got it. I saw it on the UI too:
There was a problem hiding this comment.
Do we usually just copy the template that they provide? I can find template here: https://artifacthub.io/packages/helm/spot/ocean-kubernetes-controller
There was a problem hiding this comment.
Yeah exactly! I do it through helm commands, but there are a bunch of places that we can get their template.
Copying the default template and adjusting it is how I have done all of the helm based deployments in the repo
| runAsUser: 10001 | ||
| runAsGroup: 10001 | ||
| fsGroup: 10001 | ||
| runAsUser: 1000690000 |
There was a problem hiding this comment.
Based on my understanding, both 10001 and 1000690000 are both non-root users. Why do we need to switch from one non-root user to another?
There was a problem hiding this comment.
oh I undestand why now! For some reasons, that was changed in their template:
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/dpe-dev-kubernetes-deployments
BryanFauble
changed the title
… autoscaler module
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/dpe-dev-kubernetes-deployments
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM! Thanks for doing this update!
Problem:
Solution:
https://awslabs.github.io/amazon-eks-ami/nodeadm/
https://registry.terraform.io/providers/spotinst/spotinst/latest/docs/resources/ocean_aws#user_data-1
Testing: